jer/kevo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: swap fmt print statements for logger in grpc service
Some checks failed
Go Tests / Run Tests (1.24.2) (push) Has been cancelled
Details

Browse Source
This commit is contained in:
Jeremy Tregunna 2025-05-02 23:25:42 -06:00
parent c70eb8d138
commit 917ee5e177
Signed by: jer
GPG Key ID: 1278B36BA6F5D5E4
2 changed files with 10 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
pkg/grpc/service/service.go
View File

@ -6,6 +6,7 @@ import (
"sync"
"github.com/KevoDB/kevo/pkg/common/iterator"
"github.com/KevoDB/kevo/pkg/common/log"
"github.com/KevoDB/kevo/pkg/engine/interfaces"
"github.com/KevoDB/kevo/pkg/replication"
pb "github.com/KevoDB/kevo/proto/kevo"
@ -442,7 +443,7 @@ func (s *KevoServiceServer) BeginTransaction(ctx context.Context, req *pb.BeginT
func (s *KevoServiceServer) CommitTransaction(ctx context.Context, req *pb.CommitTransactionRequest) (*pb.CommitTransactionResponse, error) {
tx, exists := s.txRegistry.Get(req.TransactionId)
if !exists {
fmt.Printf("Commit failed - transaction not found: %s\n", req.TransactionId)
log.Warn("Commit failed - transaction not found: %s", req.TransactionId)
return nil, fmt.Errorf("transaction not found: %s", req.TransactionId)
}
@ -452,11 +453,11 @@ func (s *KevoServiceServer) CommitTransaction(ctx context.Context, req *pb.Commi
}()
if err := tx.Commit(); err != nil {
fmt.Printf("Failed to commit transaction %s: %v\n", req.TransactionId, err)
log.Error("Failed to commit transaction %s: %v", req.TransactionId, err)
return &pb.CommitTransactionResponse{Success: false}, err
}
fmt.Printf("Successfully committed transaction: %s\n", req.TransactionId)
log.Debug("Successfully committed transaction: %s", req.TransactionId)
return &pb.CommitTransactionResponse{Success: true}, nil
}
@ -464,7 +465,7 @@ func (s *KevoServiceServer) CommitTransaction(ctx context.Context, req *pb.Commi
func (s *KevoServiceServer) RollbackTransaction(ctx context.Context, req *pb.RollbackTransactionRequest) (*pb.RollbackTransactionResponse, error) {
tx, exists := s.txRegistry.Get(req.TransactionId)
if !exists {
fmt.Printf("Rollback failed - transaction not found: %s\n", req.TransactionId)
log.Warn("Rollback failed - transaction not found: %s", req.TransactionId)
return nil, fmt.Errorf("transaction not found: %s", req.TransactionId)
}
@ -474,11 +475,11 @@ func (s *KevoServiceServer) RollbackTransaction(ctx context.Context, req *pb.Rol
}()
if err := tx.Rollback(); err != nil {
fmt.Printf("Failed to roll back transaction %s: %v\n", req.TransactionId, err)
log.Error("Failed to roll back transaction %s: %v", req.TransactionId, err)
return &pb.RollbackTransactionResponse{Success: false}, err
}
fmt.Printf("Successfully rolled back transaction: %s\n", req.TransactionId)
log.Debug("Successfully rolled back transaction: %s", req.TransactionId)
return &pb.RollbackTransactionResponse{Success: true}, nil
}
@ -486,7 +487,7 @@ func (s *KevoServiceServer) RollbackTransaction(ctx context.Context, req *pb.Rol
func (s *KevoServiceServer) TxGet(ctx context.Context, req *pb.TxGetRequest) (*pb.TxGetResponse, error) {
tx, exists := s.txRegistry.Get(req.TransactionId)
if !exists {
fmt.Printf("TxGet failed - transaction not found: %s\n", req.TransactionId)
log.Warn("TxGet failed - transaction not found: %s", req.TransactionId)
return nil, fmt.Errorf("transaction not found: %s", req.TransactionId)
}
@ -506,7 +507,7 @@ func (s *KevoServiceServer) TxGet(ctx context.Context, req *pb.TxGetRequest) (*p
keyStr = fmt.Sprintf("%x", req.Key)
}
fmt.Printf("Transaction get failed for key %s: %v\n", keyStr, err)
log.Debug("Transaction get failed for key %s: %v", keyStr, err)
// Return a specific "not found" response
return &pb.TxGetResponse{

4
pkg/memtable/skiplist.go
View File

@ -124,13 +124,11 @@ func NewSkipList() *SkipList {
}
// randomHeight generates a random height for a new node
// Uses a geometric distribution with p=0.5 for better balanced trees
// Each level has a 1/BranchingFactor chance of promotion to the next level
func (s *SkipList) randomHeight() int {
s.rndMtx.Lock()
defer s.rndMtx.Unlock()
// Use a geometric distribution with p=0.5
// Each level has 50% chance of promotion to next level
height := 1
for height < MaxHeight && s.rnd.Int31n(BranchingFactor) == 0 {
height++